Skip to content

fix pipeline - #1124

Merged
TatevikGr merged 1 commit into
mainfrom
fix-pipeline
Jul 28, 2026
Merged

fix pipeline#1124
TatevikGr merged 1 commit into
mainfrom
fix-pipeline

Conversation

@TatevikGr

@TatevikGr TatevikGr commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

this is fixing pipeline

Related Issue

#1123

Screenshots (if appropriate):

@TatevikGr
TatevikGr requested a review from marianaphplist July 28, 2026 09:30
@TatevikGr
TatevikGr merged commit ac082fd into main Jul 28, 2026
16 of 18 checks passed
@lwcorp

lwcorp commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The following updates are still to outdated versions, can you kindly fix?

  1. Why docker/setup-buildx-action@v2 and not docker/setup-buildx-action@v4? That's quite a difference.
  2. Why docker/login-action@v2 and not docker/login-action@v3?
  3. Why docker/build-push-action@v3 and not docker/build-push-action@v7? That's a lot of difference.

?

Also, why not updating at all the following:

  1. overtrue/phplint@9.1.2 to overtrue/phplint@9.x (x means automatic and currently it's 9.7)
  2. s3-actions/s3cmd@1.1 to s3-actions/s3cmd@3

?

@lwcorp

lwcorp commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Thanks, but what about my 5 comments?

@TatevikGr

Copy link
Copy Markdown
Contributor Author

Thanks, but what about my 5 comments?

@lwcorp builds are done from release branches, and applying a fix to main that has already been made in the release branch will only create more merge conflicts. In fact, I probably shouldn't have touched build-release file at all.
I didn't update versions because this PR was only intended to fix the current issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants